Sunshine@piefed.ca to Linux@programming.devEnglish · 5 days agoLinus Torvalds Rejects RISC-V Changes For Linux 6.17: "Garbage"www.phoronix.comexternal-linkmessage-square41linkfedilinkarrow-up11arrow-down10
arrow-up11arrow-down1external-linkLinus Torvalds Rejects RISC-V Changes For Linux 6.17: "Garbage"www.phoronix.comSunshine@piefed.ca to Linux@programming.devEnglish · 5 days agomessage-square41linkfedilink
minus-squareFizzyOrange@programming.devlinkfedilinkarrow-up0·4 days ago this is about non-generic code in generic header. (a << 16) | b is about the most generic code you can get. How is that remotely RISC-V specific?
minus-squarezygo_histo_morpheus@programming.devlinkfedilinkarrow-up0·4 days agoMaking a u32 pointer from to u16’s isn’t a generic operation because it has to make assumptions about how the pointers work (in particular what endianess they have)
minus-squareFizzyOrange@programming.devlinkfedilinkarrow-up0·4 days agoWhat makes you think it’s making a pointer? Nobody said anything about that.
minus-squarezygo_histo_morpheus@programming.devlinkfedilinkarrow-up0·4 days agoOh my bad I don’t know where I got that from lol
minus-squareFizzyOrange@programming.devlinkfedilinkarrow-up0·4 days agoNw. You’re also wrong about endianness. This function would be written exactly the same irrespective of endianness: uint32_t u16_high_low_to_u32(uint16_t high, uint16_t low) { return (high << 16) | low; } That is endian agnostic.
(a << 16) | b
is about the most generic code you can get. How is that remotely RISC-V specific?Making a u32 pointer from to u16’s isn’t a generic operation because it has to make assumptions about how the pointers work (in particular what endianess they have)
What makes you think it’s making a pointer? Nobody said anything about that.
Oh my bad I don’t know where I got that from lol
Nw. You’re also wrong about endianness. This function would be written exactly the same irrespective of endianness:
uint32_t u16_high_low_to_u32(uint16_t high, uint16_t low) { return (high << 16) | low; }
That is endian agnostic.